-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #4435
base: master
Are you sure you want to change the base?
add task solution #4435
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please try to pass all tests. Feel free to ask for help in fe_chat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! https://www.w3schools.com/css/css3_backgrounds.asp
The icon disappears on the focus. Consider fixing it
You can use Pixel perfect extension to compare your solution with Figma and pass tests
the magnifying glass doesn't disappear, but I don't understand where the error is with the text size |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls don’t ask for help in github, because this way mentors are only able to see your questions once the review is requested. Instead, pls always ask for help in fe_chat if you don't understand something so mentors can quickly help you
ok) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! GJ 👍
I added suggestions to improve your code and, maybe, fix tests)
src/style.css
Outdated
font-size: 14px; | ||
border-radius: 4px; | ||
border: 1px solid #e1e7ed; | ||
box-sizing: border-box; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this property is better to define in * selector and remove everywhere else
background-size: 11px 11px; | ||
} | ||
|
||
input:hover { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not add styles using tag selector
Instead, add a common input
class to both inputs and add all shared styles using this class (instead of repeating them in small-input and biginput)
src/style.css
Outdated
outline: none; | ||
color: inherit; | ||
} | ||
git add readme.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't be here)
box-shadow: 0 3px 8px 0 rgba(61, 78, 97, 0.2); | ||
} | ||
|
||
input:focus { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one of the reason tests fail might be overwritten by standard browser styles for placeholder
Add correct styles (font family - inherit, color, font weight) using pseudoelement:
.input::placeholder
https://developer.mozilla.org/en-US/docs/Web/CSS/::placeholder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
No description provided.