Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout_search-bar-airbnb #4460

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

SerhiiSemennikov
Copy link

  • DEMO LINK
  • TEST REPORT LINK
  • Icon implemented using background-image CSS property
  • Inputs are written inside of 'form' tag with correctly passed attributes
  • All Typical Mistakes from BEM lesson theory are checked.
  • Code follows all the Code Style Rules ❗️

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your code
The input should span the entire width of the browser window
image

The horizontal margin must be 8px
image

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!
To improve:
Don't need to hide the search icon when input is focused and remove default blue border
image

src/style.css Outdated
Comment on lines 18 to 20
body {
margin: 8px;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
body {
margin: 8px;
}

src/style.css Outdated
margin-top: 20px;
}

input {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use only class selector

Copy link

@lerastarynets lerastarynets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls deploy test reports as now they're unavailable via the link

@SerhiiSemennikov
Copy link
Author

https://serhiisemennikov.github.io/report/

Pls deploy test reports as now they're unavailable via the link

https://serhiisemennikov.github.io/report/

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done!
To improve:

  1. Remove the horizontal scroll, you need to use box-sizing property for fix it
image
  1. Remove default blue border when input is focused
image

src/style.css Outdated
Comment on lines 18 to 20
.body {
margin: 8px;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default margin

Suggested change
.body {
margin: 8px;
}

@SerhiiSemennikov
Copy link
Author

Almost done! To improve:

  1. Remove the horizontal scroll, you need to use box-sizing property for fix it
image 2. Remove default blue border when input is focused image

i do not how to remove this blue border, because i have it black?

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done!
To improve:

  1. Add border: none for input for remove blue border

  2. Don't need to hide placeholder text when input is focused and empty

image

Comment on lines +1 to +3
.body {
margin: 8px;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default value, pls remove it

Suggested change
.body {
margin: 8px;
}

Copy link

@lerastarynets lerastarynets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've got this, keep pushing forward!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants