first trial search bar #4463
Open
first trial search bar #4463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please, i think that i need help in this task, every test is failing, but i don't know why. |
pedro-ruas
suggested changes
Sep 7, 2024
There was a problem hiding this comment.
Italo, sometimes Figma counts the borders, paddings and such included in the height.
I see the mock says that the big search has 70px height, and you added that, but your search bar is bigger thatn the reference.
That's why if you take a look, your bar is actually 74px.
When adding box-sizing: border-box; to the body, you added it ONLY to the body, not to every element inside the body, maybe this is causing unexpected behavior
…lder changing the color for text color as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK
TEST REPORT LINK
Icon implemented using background-image CSS property
Inputs are written inside of 'form' tag with correctly passed attributes
All
Typical MistakesfromBEMlesson theory are checked.Code follows all the Code Style Rules ❗️