add task solution #4481
Open
add task solution #4481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jv-aquino
approved these changes
Sep 22, 2024
| > | ||
| <label class="search-bar__label search-bar__label_big"> | ||
| <input | ||
| class="search-bar__input search-bar__input_big" |
| .search-bar__label_small::after { | ||
| background-image: url(./images/Search.svg); | ||
| background-repeat: no-repeat; | ||
| background-size: contain; |
There was a problem hiding this comment.
these 3 lines could've been comprised in line 45 (.search-bar__label::after) as they are common for both
| font-weight: 300; | ||
| font-family: inherit; | ||
| box-shadow: 0 1px 8px rgba(61, 78, 97, 0.1); | ||
| outline: none; |
There was a problem hiding this comment.
when we have lots of css properties (7+) in a single selector, it's a good idea to separate some of them semantically using line breaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK
TEST REPORT LINK
Icon implemented using background-image CSS property
Inputs are written inside of 'form' tag with correctly passed attributes
All
Typical MistakesfromBEMlesson theory are checked.Code follows all the Code Style Rules ❗️