Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

finished search bar #4488

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+138 −13
Open

finished search bar #4488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ ___

❗️ Replace `<your_account>` with your Github username and copy the links to `Pull Request` description:

- [DEMO LINK](https://<your_account>.github.io/layout_search-bar-airbnb/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_search-bar-airbnb/report/html_report/)
- [DEMO LINK](https://mForkosh.github.io/layout_search-bar-airbnb/)
- [TEST REPORT LINK](https://mForkosh.github.io/layout_search-bar-airbnb/report/html_report/)

❗️ Copy this `Checklist` to the `Pull Request` description after links, and put `- [x]` before each point after you checked it.

Expand Down
36 changes: 26 additions & 10 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,32 @@
/>
</head>
<body>
<input
type="text"
data-qa="keypress"
placeholder="Try “Los Angeles“"
/>
<form class="form">
<label
for="big-bar"
class="form__label-big"
></label>

<input
type="text"
data-qa="hover"
placeholder="Try “Los Angeles“"
/>
<input
type="text"
data-qa="big"
placeholder="Try “Los Angeles“"
class="form__bar form__bar--big"
id="big-bar"
/>

<label
for="small-bar"
class="form__label-small"
></label>

<input
type="text"
data-qa="small"
placeholder="Try “Los Angeles“"
class="form__bar form__bar--small"
id="small-bar"
/>
Comment on lines +20 to +45
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add empty lines between multiline sibling blocks of HTML to add some 'air' and simplify reading. But don't add them between parent and child elements. In this case, there should be an empty line between the label and input elements, but not between the form and the first label.

</form>
</body>
</html>
111 changes: 110 additions & 1 deletion src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,110 @@
/* add styles here */
@font-face {
font-family: Avenir;
src: url(fonts/Avenir-Book.ttf);
font-weight: 400;
font-style: normal;
}

@font-face {
font-family: Avenir;
src: url(fonts/Avenir-Heavy.ttf);
font-weight: 900;
font-style: normal;
}

body {
margin-top: 20px;
}

Comment on lines +15 to +17
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be consistent with your margins (Add only top or bottom, but not both). It's better to avoid potential margin collapse issues by sticking to either top or bottom margins for elements. Consider removing the margin-top from the body and applying it to the first element within the body if necessary.

/* #region form */

.form {
display: flex;
position: relative;
flex-direction: column;
gap: 20px;
}

.form__bar {
/* element settings */
box-sizing: border-box;
border: 1px solid #e1e7ed;
border-radius: 4px;
font-family: Avenir, Helvetica, sans-serif;

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to use fallback fonts - alternative font-family in case the main one doesn't work. It's recommended to have a generic font family as a fallback in case the primary font fails to load. In this case, 'sans-serif' is already present, which is good practice.

/* content ssetings */
color: #3d4e61;
font-weight: 400;
}

.form__bar--big {
height: 70px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't fix container size (if there is no such a requirement). Setting a fixed height on input fields can make them less flexible. Consider using padding and letting the content dictate the size of the input field.

padding-left: 62px;
font-size: 16px;
box-shadow: 0 1px 8px 0 #3d4e611a;
}

.form__bar--small {
height: 42px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't fix container size (if there is no such a requirement). As with the previous comment, consider using padding instead of a fixed height to allow the content to dictate the size of the input field.

padding-left: 33px;
font-size: 14px;
box-shadow: 0 1px 8px 0 #3d4e611a;
}

.form__bar--big::placeholder {
font-weight: 400;
color: #3d4e61;
}

.form__bar--small::placeholder {
font-weight: 400;
color: #3d4e61;
}

.form__bar--big:hover {
box-shadow: 0 3px 8px 0 #3d4e6133;
}

.form__bar--small:hover {
box-shadow: 0 3px 8px 0 #3d4e6133;
}

.form__bar--big:focus {
outline: none;
background: linear-gradient(180deg, #fff 0%, #f6f6f7 100%);
box-shadow: (0 4px 4px #3d4e6133);
font-weight: 900;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a typo in the box-shadow value. The correct syntax for box-shadow does not include parentheses around the values. It should be box-shadow: 0 4px 4px rgba(61, 78, 97, 0.2);.

}

.form__bar--small:focus {
background: linear-gradient(180deg, #fff 0%, #f6f6f7 100%);
box-shadow: none;
outline: none;
font-weight: 900;
}

.form__label-big {
position: absolute;
top: 25px;
left: 26px;
height: 19px;
width: 19px;
z-index: 1;
background-image: url(images/Search.svg);
background-repeat: no-repeat;
background-size: contain;
}

.form__label-small {
position: absolute;
top: 105px;
left: 13px;
height: 11px;
width: 11px;
z-index: 1;
background-image: url(images/Search.svg);
background-repeat: no-repeat;
background-size: contain;
}

/* #endregion */
Loading