-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
search bar #4494
base: master
Are you sure you want to change the base?
search bar #4494
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on the Pull Request! 👍 Just a little note for the future: remember to format your attributes by starting them on a new line with a 2-space indentation. This will help in keeping your code clean and readable. Keep up the good work!
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
<link | ||
rel="stylesheet" | ||
href="style.css" | ||
href="styles/style.css" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The attributes for the link
tag should start on a new line with 2-space indentation related to the tag, as per the checklist for keeping attributes correctly formatted.
<link | ||
href="https://fonts.googleapis.com/css2?family=Sen:wght@400..800&display=swap" | ||
rel="stylesheet" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The attributes for the link
tag should start on a new line with 2-space indentation related to the tag, as per the checklist for keeping attributes correctly formatted.
/> | ||
</head> | ||
<body> | ||
<body class="search"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The class
attribute value should represent the meaning of the content, not the styles or tag names. Please ensure that the class name 'search' accurately represents the content of the body
element.
<input | ||
class="search__big search__big-img" | ||
type="text" | ||
data-qa="keypress" | ||
data-qa="keypress big" | ||
placeholder="Try “Los Angeles“" | ||
name="big" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The attributes for the input
tag should start on a new line with 2-space indentation related to the tag, as per the checklist for keeping attributes correctly formatted.
<input | ||
class="search__small search__small-img" | ||
type="text" | ||
data-qa="hover" | ||
data-qa="hover small" | ||
placeholder="Try “Los Angeles“" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The attributes for the input
tag should start on a new line with 2-space indentation related to the tag, as per the checklist for keeping attributes correctly formatted.
No description provided.