Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add solution #4587

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

add solution #4587

wants to merge 5 commits into from

Conversation

lolekmakso
Copy link

  • DEMO LINK

  • TEST REPORT LINK

  • Icon implemented using background-image CSS property

  • Inputs are written inside of 'form' tag with correctly passed attributes

  • All Typical Mistakes from BEM lesson theory are checked.

  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Thank you for your hard work on this project! While your code meets many of the task requirements, there are a few critical issues that need to be addressed before we can approve the pull request:

  1. Font Weight for Small Search Bar: The font-weight for the small search bar should be 300 as per the task requirements, but it is currently set to 400. This needs to be corrected to meet the core requirements.

  2. Incorrect data-qa Attribute: The data-qa attribute for the small search form is incorrectly set. It should be data-qa="small" instead of data-qa="hover small". This is important for ensuring the correct functionality if this attribute is used for testing or tracking.

  3. CSS Selector Usage: The use of tag names for styling, except for html and body, is against the checklist requirements. This needs to be adjusted to comply with best practices and project guidelines.

  4. Missing Fallback Fonts: The absence of fallback fonts in the @font-face definitions is a critical issue that can affect the display of your application if the primary font is unavailable.

  5. HTML Formatting and Line Length: Ensure that HTML attributes are formatted correctly and that lines do not exceed 80 characters for better readability and maintainability.

Please address these issues to ensure that your code fully complies with the task requirements and maintains high standards of quality. Once these changes are made, we can proceed with approval. Keep up the great work, and don't hesitate to reach out if you have any questions! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

src/index.html Outdated Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
src/style.css Outdated Show resolved Hide resolved
src/style.css Outdated Show resolved Hide resolved
src/style.css Outdated Show resolved Hide resolved
@lolekmakso
Copy link
Author

fixed errors

@lolekmakso
Copy link
Author

  • DEMO LINK

  • TEST REPORT LINK

  • Icon implemented using background-image CSS property

  • Inputs are written inside of 'form' tag with correctly passed attributes

  • All Typical Mistakes from BEM lesson theory are checked.

  • Code follows all the Code Style Rules ❗️

@lolekmakso lolekmakso closed this Nov 6, 2024
@lolekmakso lolekmakso reopened this Nov 6, 2024
@lolekmakso lolekmakso closed this Nov 6, 2024
@lolekmakso lolekmakso reopened this Nov 6, 2024
@lolekmakso lolekmakso closed this Nov 6, 2024
@lolekmakso
Copy link
Author

  • DEMO LINK

  • TEST REPORT LINK

  • Icon implemented using background-image CSS property

  • Inputs are written inside of 'form' tag with correctly passed attributes

  • All Typical Mistakes from BEM lesson theory are checked.

  • Code follows all the Code Style Rules ❗️

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done!
To improve:

  1. Don't need to hide the search icon when input is focused
image image

@lolekmakso
Copy link
Author

Sorry, I just didn't refresh gh-page

Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants