-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add solution #4587
base: master
Are you sure you want to change the base?
add solution #4587
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work on this project! While your code meets many of the task requirements, there are a few critical issues that need to be addressed before we can approve the pull request:
-
Font Weight for Small Search Bar: The
font-weight
for the small search bar should be300
as per the task requirements, but it is currently set to400
. This needs to be corrected to meet the core requirements. -
Incorrect
data-qa
Attribute: Thedata-qa
attribute for the small search form is incorrectly set. It should bedata-qa="small"
instead ofdata-qa="hover small"
. This is important for ensuring the correct functionality if this attribute is used for testing or tracking. -
CSS Selector Usage: The use of tag names for styling, except for
html
andbody
, is against the checklist requirements. This needs to be adjusted to comply with best practices and project guidelines. -
Missing Fallback Fonts: The absence of fallback fonts in the
@font-face
definitions is a critical issue that can affect the display of your application if the primary font is unavailable. -
HTML Formatting and Line Length: Ensure that HTML attributes are formatted correctly and that lines do not exceed 80 characters for better readability and maintainability.
Please address these issues to ensure that your code fully complies with the task requirements and maintains high standards of quality. Once these changes are made, we can proceed with approval. Keep up the great work, and don't hesitate to reach out if you have any questions! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
fixed errors |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I just didn't refresh gh-page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
DEMO LINK
TEST REPORT LINK
Icon implemented using background-image CSS property
Inputs are written inside of 'form' tag with correctly passed attributes
All
Typical Mistakes
fromBEM
lesson theory are checked.Code follows all the Code Style Rules ❗️