add task solution #5054
add task solution #5054
Conversation
There was a problem hiding this comment.
Great job on meeting the task requirements! 🎉 Your HTML and CSS structure is well-formed and adheres to the specified constraints. While there are a couple of minor improvements suggested, such as adjusting the order of CSS imports and refining the .stars--0 selector, these do not impact the core functionality. Keep up the excellent work and consider these suggestions for future enhancements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| .stars--0 .stars__star:nth-child(-n + 0) { | ||
| background-image: url('images/star-active.svg'); | ||
| } |
There was a problem hiding this comment.
The selector .stars--0 .stars__star:nth-child(-n + 0) will not apply any styles because nth-child(-n + 0) does not select any elements. If the intention is to have no active stars, this line can be removed or adjusted to reflect that intention.
| @import 'stars.css'; | ||
| @import 'reset.css'; |
There was a problem hiding this comment.
It's generally a good practice to import reset styles before other styles to ensure that the reset is applied first. Consider switching the order of these imports.
DEMO LINK
TEST REPORT LINK
[x ] Yellow stars are added with container modifier + pseudo-selector (NO extra classes)
[x ] Each BEM block has its own separate file
All
Typical MistakesfromBEMlesson theory are checked.Code follows all the Code Style Rules ❗️