add task solution #166
Open
add task solution #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And678
suggested changes
Aug 7, 2023
src/modules/copyFile.js
Outdated
Comment on lines
11
to
13
| const data = fs.readFileSync(sourcePath, 'utf-8'); | ||
|
|
||
| fs.writeFileSync(destPath, data, 'utf-8'); |
There was a problem hiding this comment.
Not all files are utf-8, don't pass this param and work with raw buffers
Suggested change
| const data = fs.readFileSync(sourcePath, 'utf-8'); | |
| fs.writeFileSync(destPath, data, 'utf-8'); | |
| const data = fs.readFileSync(sourcePath); | |
| fs.writeFileSync(destPath, data); |
There was a problem hiding this comment.
Try copying an executable file, it will not work afterwards
And678
suggested changes
Aug 7, 2023
src/modules/copyFile.js
Outdated
Comment on lines
11
to
13
| const data = fs.readFileSync(sourcePath, 'utf-8'); | ||
|
|
||
| fs.writeFileSync(destPath, data, 'utf-8'); |
There was a problem hiding this comment.
Try copying an executable file, it will not work afterwards
src/modules/copyFile.js
Outdated
|
|
||
| fs.writeFileSync(destPath, data, 'utf-8'); | ||
| } catch (error) { | ||
| throw new Error('Something went wrong: ', error); |
There was a problem hiding this comment.
Why throw new Error? At least save the message. Also the second param is wrong
Suggested change
| throw new Error('Something went wrong: ', error); | |
| throw new Error('Something went wrong: ' + error.message); |
src/app.js
Outdated
Comment on lines
15
to
16
| const sourcePath = path.join(__dirname, source); | ||
| const destPath = path.join(__dirname, dest); |
There was a problem hiding this comment.
Don't join __dirname, your program will not work outside of src
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.