-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #1809
base: master
Are you sure you want to change the base?
Solution #1809
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on implementing the Car
and CarWashStation
classes! 🎉 Your code meets the task requirements and constraints effectively. There are a couple of minor issues to address for future improvements:
-
Return Type Annotations: The
__init__
methods should have a return type ofNone
instead ofint
. This is because constructors in Python do not return a value. -
Condition in
serve_cars
Method: Ensure that the condition for washing cars iscar.clean_mark < self.clean_power
to align with the task description.
These are minor adjustments and do not significantly impact the functionality of your code. Keep up the great work, and happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
# write your code here | ||
pass | ||
def __init__(self, comfort_class: int, clean_mark: int , | ||
brand: str) -> int: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The __init__
method should have a return type of None
, not int
. The constructor in Python does not return a value, so the correct annotation is -> None
.
# write your code here | ||
pass | ||
def __init__(self, distance_from_city_center: float, clean_power: int, | ||
average_rating: float, count_of_ratings: int) -> int: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The __init__
method should have a return type of None
, not int
. The constructor in Python does not return a value, so the correct annotation is -> None
.
def serve_cars(self, cars: list) -> float: | ||
income = 0.0 | ||
for car in cars: | ||
if car.clean_mark <= self.clean_power: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The condition should be car.clean_mark < self.clean_power
to ensure only cars with a clean_mark
less than the clean_power
are washed, as per the task description.
No description provided.