Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #1661

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Solution #1661

wants to merge 3 commits into from

Conversation

olena-ole
Copy link

@olena-ole olena-ole closed this Jul 25, 2023
@olena-ole olena-ole reopened this Jul 25, 2023
@meforoma meforoma requested a review from And678 July 25, 2023 11:50
vladmakohon
vladmakohon approved these changes Jul 25, 2023
View reviewed changes
Copy link

@vladmakohon vladmakohon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

src/App.tsx Outdated
export const App: React.FC = () => (
<div className="App">
<h1>Dynamic list of Goods</h1>
const hadleClick = (fetchFromServer: () => Promise<Good[]>) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo here

anstsot
anstsot approved these changes Jul 26, 2023
View reviewed changes
Copy link

@anstsot anstsot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, approving:sparkles:

src/App.tsx Outdated
Comment on lines 12 to 15
fetchFromServer()
.then(goods => {
setCurrentGoods(goods);
setErrorMessage('');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fetchFromServer()
.then(goods => {
setCurrentGoods(goods);
setErrorMessage('');
setErrorMessage('');
fetchFromServer()
.then(goods => {
setCurrentGoods(goods);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladmakohon vladmakohon vladmakohon approved these changes

@anstsot anstsot anstsot approved these changes

@And678 And678 Awaiting requested review from And678

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olena-ole @anstsot @vladmakohon