people table completed #1695
people table completed #1695
Conversation
There was a problem hiding this comment.
Great job on implementing the React application! 🎉 Your code meets all the core requirements and functions as expected. While there are a few minor issues, such as a typo in the word "response" and some redundancy in the routing setup, they don't impact the overall functionality. Keep up the good work, and consider addressing these minor points to further enhance your code quality in the future! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
src/index.tsx
Outdated
| <Route path="people" element={<PeoplePage />}> | ||
| <Route index element={<PeoplePage />} /> | ||
| <Route path=":personId" element={<PeoplePage />} /> |
There was a problem hiding this comment.
The nested Route for PeoplePage with index and :personId paths seems redundant, as both render the same PeoplePage component. Consider differentiating the components or paths if they are intended to display different content.
| const { personId } = useParams(); | ||
| const selectedPersonId = personId; | ||
|
|
||
| function getPeopleWithParents(peopleResponce: Person[]) { |
There was a problem hiding this comment.
There is a typo in the function name getPeopleWithParents. It should be getPeopleWithParents instead of getPeopleWithParents.
src/pages/PeoplePage.tsx
Outdated
| useEffect(() => { | ||
| setIsPeopleLoading(true); | ||
| getPeople() | ||
| .then(responce => setPeople(getPeopleWithParents(responce))) |
There was a problem hiding this comment.
There is a typo in the word responce. It should be response.
DEMO LINK