Develop #1697
Develop #1697
Conversation
There was a problem hiding this comment.
Great job on implementing the task requirements! 🎉 The code is well-structured and meets the core functionality. There are a couple of minor improvements you could consider: refining the error handling in PeoplePage.tsx to ensure the error message only appears when necessary, and updating the route path for consistency. Keep up the great work and happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| <div className="container"> | ||
| <Routes> | ||
| <Route path="/" element={<HomePage />} /> | ||
| <Route path="home" element={<Navigate to="/" replace />} /> |
There was a problem hiding this comment.
The route path 'home' should be '/home' to maintain consistency with the other paths and ensure proper navigation. This might not cause a problem in this specific setup due to the redirect, but it's good practice to keep paths consistent.
| {isError && ( | ||
| <p data-cy="peopleLoadingError" className="has-text-danger"> | ||
| Something went wrong | ||
| </p> | ||
| )} |
There was a problem hiding this comment.
The error message is displayed even if there are people loaded successfully. Consider adding a condition to check if 'people' is empty before displaying the error message to avoid confusion.
https://Pidsvynok.github.io/react_people-table-basics/