react catalog #181
Open
react catalog #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The home page link leads to a 404 page (on other pages as well): Align content on the product page according to the design (also, it'd be nice for you to make sure it looks good on screens with 1920px width or more, not only 1440px. Most likely it will be open (by HRs) from laptops with such resolution): |
TarasHoliuk
suggested changes
Jun 13, 2023
src/components/Category/Category.tsx
Outdated
| </h2> | ||
|
|
||
| <p className="image__subtitle"> | ||
| 71 models |
Comment on lines
62
to
69
| Screen | ||
| {' '} | ||
| <br /> | ||
| {' '} | ||
| Capacity | ||
| {' '} | ||
| <br /> | ||
| {' '} |
src/App.tsx
Outdated
Comment on lines
25
to
26
| const [likedProducts, setLikedProducts] = useState<Phone[]>([]); | ||
| const [cartProducts, setCartProducts] = useState<CartItem[]>([]); |
There was a problem hiding this comment.
I'd recommend you create useLocalStorage custom hook to handle values stored in the local storage instead of saving them here and passing them as props to child components
you may google it or ask in the chat if you need help
TarasHoliuk
approved these changes
Jun 14, 2023
src/components/Category/Category.tsx
Outdated
Comment on lines
34
to
36
| {phones.length} | ||
| {' '} | ||
| models |
There was a problem hiding this comment.
Suggested change
| {phones.length} | |
| {' '} | |
| models | |
| {`${phones.length} models`} |
fix all similar cases
the variant with string template looks much laconic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://katerynashylina.github.io/react_phone-catalog