Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #189

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add task solution #189

wants to merge 3 commits into from

Conversation

NikaNika12
Copy link

@NikaNika12 NikaNika12 commented Jul 17, 2023 •
edited
Loading

DEMO LINK

на странице детального описания продукта нужна помощь в реализации ссылки

demetrxx
demetrxx suggested changes Jul 17, 2023
View reviewed changes
Copy link

@demetrxx demetrxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have any question regarding tasks, ask them in appropriate chat.
Add demo link

@NikaNika12 NikaNika12 requested a review from demetrxx July 17, 2023 13:24
sTorba24
sTorba24 suggested changes Jul 17, 2023
View reviewed changes
Copy link

@sTorba24 sTorba24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! rerequest review when you fix everything

@NikaNika12
Copy link
Author

все работает

@NikaNika12 NikaNika12 requested a review from sTorba24 July 17, 2023 19:11
polosanya
polosanya suggested changes Jul 18, 2023
View reviewed changes
Copy link

@polosanya polosanya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep up the good work! A few moments that would be great to fix

  1. Alphabetical sort doesn't work correctly. Same with newest
    image
  2. There is a bug with "Back to top" button
    back
  3. Nothing changes if I choose a different color/capacity
    colors

@NikaNika12
Copy link
Author

NikaNika12 commented Jul 18, 2023 •
edited
Loading

  1. сортировку исправила
  2. кнопка скрола наверх работает правильно вот код ее
    const handleScrollToTop = () => {
    window.scrollTo({
    top: 0,
    left: 0,
    behavior: 'smooth',
    });
    };
  3. что касается выбора цвета и размера, то в задании указано след - Hide Available colors and Select capacity for now
    так как в предоставляемой apı нет необходимых свойств поэтому я реализовала только дизайн без функционала

demetrxx
demetrxx approved these changes Jul 19, 2023
View reviewed changes
Copy link

@demetrxx demetrxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 👍 Go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demetrxx demetrxx demetrxx approved these changes

@sTorba24 sTorba24 Awaiting requested review from sTorba24

@polosanya polosanya Awaiting requested review from polosanya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NikaNika12 @sTorba24 @polosanya @demetrxx