Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #191

Open
wants to merge 60 commits into
base: master
Choose a base branch
from
Open

Develop #191

wants to merge 60 commits into from

Conversation

Vo7kov
Copy link

@Vo7kov Vo7kov commented Jul 21, 2023

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to deploy your BE, because there is nothing to check from the website's functionality (

}) => (
<Link
to={where}
className={`button button--main ${className}`}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to use classNames package

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vo7kov Vo7kov requested a review from etojeDenys July 22, 2023 14:07
@Vo7kov
Copy link
Author

Vo7kov commented Jul 22, 2023

I've added burger for mobile screens

Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About appear menu replied in chat.
Still no functionality in website.

}) => (
<Link
to={where}
className={`button button--main ${className}`}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found the bug

Screen.Recording.2023-07-23.at.09.51.23.mov

we can just render the burger on click without creating a new burger route

@Vo7kov
Copy link
Author

Vo7kov commented Aug 21, 2023

I've added multilang, but I'm not sure, that I did it correct. Also, all bugs fixed and I added transitions

@Vo7kov Vo7kov requested a review from etojeDenys August 21, 2023 18:46
Copy link

@maxim2310 maxim2310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, but your translation doesnt work
image

@Vo7kov
Copy link
Author

Vo7kov commented Sep 21, 2023

I've been made a lot of changes since last review. I prefer to fix some code mistakes, if it is and go on. If there are no errors - just reject it

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, keep going

Copy link

@loralevitska loralevitska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job overall! Just couple tiny things needs to be fixed before approval)

  • make sure that all interactive elements have a cursor pointer on hover

  • nothing happens on buy
    image

  • search is visible for some reason (after menu open/сlose)
    image

  • it is not entirely clear how to add a product to the basket or to favorites
    if there is no possibility, then add a message that this has not been implemented yet, because now everything is simply empty, and it is not clear how to add

@Vo7kov
Copy link
Author

Vo7kov commented Nov 19, 2023

I dont know why 'buy' button isnt works on your computer, on my computer everything is ok. To prove that, I attach video https://drive.google.com/file/d/1ux7IXpxhe2_LLkJA5aVJ_c23LuYuCKmF/view?usp=sharing. Other bugs have been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants