-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #191
base: master
Are you sure you want to change the base?
Develop #191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try to deploy your BE, because there is nothing to check from the website's functionality (
}) => ( | ||
<Link | ||
to={where} | ||
className={`button button--main ${className}`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better to use classNames
package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added burger for mobile screens |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About appear menu replied in chat.
Still no functionality in website.
}) => ( | ||
<Link | ||
to={where} | ||
className={`button button--main ${className}`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
found the bug
Screen.Recording.2023-07-23.at.09.51.23.mov
we can just render the burger on click without creating a new burger route
I've added multilang, but I'm not sure, that I did it correct. Also, all bugs fixed and I added transitions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been made a lot of changes since last review. I prefer to fix some code mistakes, if it is and go on. If there are no errors - just reject it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, keep going
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job overall! Just couple tiny things needs to be fixed before approval)
-
make sure that all interactive elements have a cursor pointer on hover
-
it is not entirely clear how to add a product to the basket or to favorites
if there is no possibility, then add a message that this has not been implemented yet, because now everything is simply empty, and it is not clear how to add
I dont know why 'buy' button isnt works on your computer, on my computer everything is ok. To prove that, I attach video https://drive.google.com/file/d/1ux7IXpxhe2_LLkJA5aVJ_c23LuYuCKmF/view?usp=sharing. Other bugs have been fixed |
https://vo7kov.github.io/react_cloth-catalog/
Please, check
README