Develop #193
Open
Develop #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deleting favs. Created CartExample and Dropdown menu added
DarkMistyRoom
suggested changes
Jul 24, 2023
There was a problem hiding this comment.
Great job!
- please fix the placeholder
-
lead to the top of the page on opening the section(VIDEO)
-
remove
query=when it's empty
Suggestions for improvement:
-
it would be great to make sliders work smoothly
-
and make the search order-insensitive
DarkMistyRoom
approved these changes
Jul 25, 2023
src/Reducer/store.ts
Outdated
Comment on lines
26
to
31
| export type AppThunk<ReturnType = void> = ThunkAction< | ||
| ReturnType, | ||
| RootState, | ||
| unknown, | ||
| Action<string> | ||
| >; |
There was a problem hiding this comment.
Suggested change
| export type AppThunk<ReturnType = void> = ThunkAction< | |
| ReturnType, | |
| RootState, | |
| unknown, | |
| Action<string> | |
| >; | |
| export type AppThunk<ReturnType = void> = ThunkAction< | |
| ReturnType, | |
| RootState, | |
| unknown, | |
| Action<string> | |
| >; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://vasyliev-anton.github.io/react_phone-catalog/