phone-catalog (desktop version ) was created #194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polosanya
suggested changes
Jul 24, 2023
Anastasiya145
commented
Jul 28, 2023
There was a problem hiding this comment.
Hi! I fixed all the bugs and improved the logic of loaders&filtering etc
Also, mobile and tablets versions were created
For them additionally, I used Slick Slider
Please check the code if there are some mistakes because I want to add it to my portfolio
Thanks!
VitaliyBondarenko1982
suggested changes
Jul 28, 2023
There was a problem hiding this comment.
Good job.
Needs some improvements.
- not fixed comment about amount of items.
- horizontal scroll and broken slider layout on some width (~ 800px)
- center product cards and make some space from left for filter and other content on width from mobile to desctop
- check slider. looks like some unexpected shift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://anastasiya145.github.io/react_phone-catalog/#/ - DEMO