solution #214
Open
solution #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anastasiiavorobiova
suggested changes
Sep 3, 2023
|
there is no more pages, API doesn't have any other data, such as tablets or accessories |
volodymyr-soltys97
suggested changes
Sep 4, 2023
|
Прошу проверить, вроде все сделал, вопрос остается на счет страниц которых нет и ошибок, стоит ли потом заморочится более красивее сделать, с какой то картинкой и стоит ли заморочится заполнить как то потом райтс и контактс, если контактс еще можно придумать то вот райтс не знаю что писать |
volodymyr-soltys97
suggested changes
Sep 15, 2023
There was a problem hiding this comment.
- I think that when you click the button below again, it would be logical to remove the product from the cart and change the text to add it again
- Regarding the pages that are not there, I think it is worth bothering and implementing the design a little better, for example, that the pages are in the process of development and some kind of picture, or something similar
IvanFesenko
suggested changes
Sep 15, 2023
|
на гитхабе и локально на компьютере нет проблем с изображением карточек, как найти проблему? |
IvanFesenko
suggested changes
Sep 15, 2023
|
вроде пофиксил на файрфокс была проблема вроде как |
|
у меня во всех браузерах с бордерами все ок сейчас, проверил на 4 браузерах |
added 2 commits
October 17, 2023 23:55
volodymyr-soltys97
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK
Проверьте пожалуйста повторно, необходимо для эмплоймента! Спасибо!