Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_for_mentor #217

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

test_for_mentor #217

wants to merge 8 commits into from

Conversation

zipic
Copy link

@zipic zipic commented Sep 7, 2023

@TarasHoliuk
Copy link

How does it look now:
image

And 404 page on any link click

Copy link

@TarasHoliuk TarasHoliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, make sure the App works as expected
If you have any questions feel free to ask in the chat or join to Q&A session

src/App.tsx Outdated
);
const App = () => {
return (
<BrowserRouter>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend you use HashRouter in this case

src/App.tsx Outdated
Comment on lines 22 to 24
<Route path="/home" element={<Navigate to="/" />} />
<Route path="/" element={<HomeTab />} />
<Route path="/phones" element={<PhonesTab />} />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be more Routes. Also, you have to cover paths to a separate product, for example: /phones/somePhoneID

@zipic
Copy link
Author

zipic commented Sep 10, 2023

please not review

Copy link

@IvanFesenko IvanFesenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TarasHoliuk
Copy link

  1. Add favicon

  2. The image on the product page looks suboptimal:
    image

  3. When clicking on different colors link is broken (capacity links are broken initially):
    image

  4. The header/page is still not full-width. The search looks not good. The selected tab is not highlighted.
    image

  5. Can't remove this item from cart (also, may sure it works fine on the favorites page):

image

  1. Typo:
    image

  2. Footer always should be at the bottom of the page:
    image

Copy link

@TarasHoliuk TarasHoliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ 👍
But there are things that should be fixed (check comments)

Copy link

@lerastarynets lerastarynets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls watch the video review via the link

Copy link

@IvanFesenko IvanFesenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pagination issue - you should reset selected page in case Items per page change
https://github.com/mate-academy/react_phone-catalog/assets/61904995/0bef21e5-346a-47eb-9130-0491108269d3

Copy link

@IvanFesenko IvanFesenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants