-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_for_mentor #217
base: master
Are you sure you want to change the base?
test_for_mentor #217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, make sure the App works as expected
If you have any questions feel free to ask in the chat or join to Q&A session
src/App.tsx
Outdated
); | ||
const App = () => { | ||
return ( | ||
<BrowserRouter> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend you use HashRouter
in this case
src/App.tsx
Outdated
<Route path="/home" element={<Navigate to="/" />} /> | ||
<Route path="/" element={<HomeTab />} /> | ||
<Route path="/phones" element={<PhonesTab />} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be more Routes. Also, you have to cover paths to a separate product, for example: /phones/somePhoneID
please not review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content doesn't centered. There are no mobile/table version
https://github.com/mate-academy/react_phone-catalog/assets/61904995/436639f8-09be-4230-8204-b78c2d99c213
Imposible to change value. Page not havee 100% width
https://github.com/mate-academy/react_phone-catalog/assets/61904995/616611b1-1eed-4b1f-b772-0db5fdb5c1a2
add favIcon
Impossible to open phone page
https://github.com/mate-academy/react_phone-catalog/assets/61904995/37a82397-1f2f-4ebd-bce3-3aecb09000bd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ 👍
But there are things that should be fixed (check comments)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls watch the video review via the link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pagination issue - you should reset selected page in case Items per page change
https://github.com/mate-academy/react_phone-catalog/assets/61904995/0bef21e5-346a-47eb-9130-0491108269d3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well done
https://zipic.github.io/react_phone-catalog