Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_for_mentor #217

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

test_for_mentor #217

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9ae1eb6
test
zipic Sep 7, 2023
c434b60
some-changes-not-review
zipic Sep 10, 2023
441f4d5
fixed
zipic Sep 11, 2023
bfaf6b4
have_question_not_review
zipic Sep 12, 2023
6332d8d
comleted
zipic Sep 24, 2023
f5d61a9
fix__comments
zipic Sep 25, 2023
0b6a12c
changed
zipic Sep 25, 2023
79de33f
fixed
zipic Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
- If you work in a team follow the [Work in a team guideline](https://github.com/mate-academy/react_task-guideline/blob/master/team-flow.md#how-to-work-in-a-team)

## Description
Implement Products catalog following [this design](https://www.figma.com/file/uEetgWenSRxk9jgiym6Yzp/Phone-catalog-redesign?node-id=1%3A2).
Implement Products catalog following [this design](httpsx://www.figma.com/file/uEetgWenSRxk9jgiym6Yzp/Phone-catalog-redesign?node-id=1%3A2).

Use [products](https://mate-academy.github.io/react_phone-catalog/api/products.json)
and [product details](https://mate-academy.github.io/react_phone-catalog/api/products/dell-streak-7.json)
Expand Down Expand Up @@ -116,3 +116,5 @@ to links container.
### Other tasks
1. Add `NotFoundPage` containing text `Page not found` for all the other URLs with the link to `HomePage`
1. Implement `Phone was not found` state for the `PhoneDetailsPage` if there is no phone with a given `phoneId` on the server

https://zipic.github.io/
32,943 changes: 20,679 additions & 12,264 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 4 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@
"bulma": "^0.9.3",
"react": "^17.0.2",
"react-dom": "^17.0.2",
"react-scripts": "^4.0.3"
"react-router-dom": "^6.15.0",
"react-scripts": "^4.0.3",
"uuid": "^9.0.0"
},
"devDependencies": {
"@cypress/webpack-dev-server": "^1.8.4",
Expand All @@ -23,6 +25,7 @@
"@types/node": "^17.0.23",
"@types/react": "^17.0.43",
"@types/react-dom": "^17.0.14",
"@types/uuid": "^9.0.3",
"cypress": "^9.5.3",
"eslint": "^7.32.0",
"eslint-plugin-cypress": "^2.11.2",
Expand Down
Loading
Loading