Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation #486

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Implementation #486

wants to merge 3 commits into from

Conversation

Vitalii-Belostotskiy
Copy link

anastasiiavorobiova
anastasiiavorobiova suggested changes Aug 20, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Screenshot 2024-08-20 at 15 31 55
No need to add the page if there are no items to show

SanyaBratashchuk
SanyaBratashchuk suggested changes Aug 20, 2024
View reviewed changes
Copy link

@SanyaBratashchuk SanyaBratashchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
set 1-st page as active on itemsOnPage change

anastasiiavorobiova
anastasiiavorobiova suggested changes Aug 21, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Consider always showing the footer at the bottom of the page
Screenshot 2024-08-21 at 16 28 03

Also, the opening of the mobile menu doesn't work after opening and closing it

anastasiiavorobiova
anastasiiavorobiova approved these changes Aug 23, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anastasiiavorobiova anastasiiavorobiova anastasiiavorobiova approved these changes

@SanyaBratashchuk SanyaBratashchuk Awaiting requested review from SanyaBratashchuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vitalii-Belostotskiy @SanyaBratashchuk @anastasiiavorobiova