Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Srtrace/react phone catalog solution #491

Open
wants to merge 51 commits into
base: master
Choose a base branch
from
Open

Srtrace/react phone catalog solution #491

wants to merge 51 commits into from

Conversation

SrTrace
Copy link

@SrTrace SrTrace commented Aug 26, 2024

@SrTrace
delete component, fixed eslint err
9eb63c8
@SrTrace
added media query for lg screen
d0f7256
@SrTrace
added layout Category component
4e1efb9
@SrTrace
added Footer layout, ids for sections
8c6e45a
@SrTrace
refactoring Header, Aside styles
89ccc08
@SrTrace
refactor icons with svg, added svg sprite
760b3e3
@SrTrace
added icons to top bar, fixed styles for topbar links
b39d5f4
@SrTrace
added media queries for tablets, added icons to Header, fix styles in…
2b5c557 
… Welcome
@SrTrace
added styles, media queries for tablet layout
5cbd48c
@SrTrace
added media queries for desktop screens
709422b
@SrTrace
fixed styles for Footer nav, added layout ProductPage
e5c7373
@SrTrace
refactored styles for Card component
7d167f2
@SrTrace
fixed styles for ProductFilter select, added grid for ProductContent
6d827be
@SrTrace
fixed styles for ProductFilter select, added grid for ProductContent
32ce2e8
@SrTrace
refactor styles for Card, added media queries for ProductPage, added …
747a9dc 
…styles for ProductFilter, fixed Footer for low content page
@SrTrace
added layout ProductDetailsPage, added styles scss for this page
94ee21a
@SrTrace
refactored file structure, adde media query for ItemPage
4186803
@SrTrace
refactored file structure, added Favorite page, added Cart page, crea…
a47c4ea 
…ted Cart-item component
@SrTrace
added styles and media queries for Cart-page
ce8fc89
@SrTrace
added favicon and title for app, added Not-Found-Page
96ad2cb
@SrTrace
added api to src
8079a65
@SrTrace
refactor Card, added Context for favorites, implement localStorage fo…
c81b41c 
…r favorites
@SrTrace
added local storage for favorites, fetch api, fixed some styles
8cec262
@SrTrace
refactored file structure for hook useFavorites
14ee7b3
@SrTrace
implement react-router-dom, create Root, add NavLink to nav
e4ec74e
@SrTrace
implement Context for products data, fixed some logic for ItemPage
feec8ff
@SrTrace
implement pagination for CatalogPage, sorting items and changing page
e7c833e
@SrTrace
implement scroll to top, fix link for Back button, fixed Breadcrumbs
e1ba660
@SrTrace
implement lib react-paginate, start fixing params in CatalogPage
4fa9dd0
@SrTrace
fixed redirecting from SideMenu
b2029ac
SanyaBratashchuk
SanyaBratashchuk suggested changes Aug 26, 2024
View reviewed changes
Copy link

@SanyaBratashchuk SanyaBratashchuk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data fetching is broken
image

@SrTrace
Copy link
Author

SrTrace commented Aug 26, 2024

Now it's okay. I fixed the path to the API, and it seems to be working.

SanyaBratashchuk
SanyaBratashchuk suggested changes Aug 26, 2024
View reviewed changes
Copy link

@SanyaBratashchuk SanyaBratashchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
color buttons should have different colors

@SrTrace
Copy link
Author

SrTrace commented Aug 27, 2024

I have changed the button colors according to Apple's color palette. Now it looks a little bit better :)

volodymyr-soltys97
volodymyr-soltys97 suggested changes Aug 27, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your page

  1. Add transition for hover effects here
image
  1. Don't need to hide menu when search is open
image
  1. These buttons must be are on the same vertical line
image

@SrTrace
Copy link
Author

SrTrace commented Aug 27, 2024

Okay, it’s fixed! I added a hover transition to the card button, made the navigation menu visible when the search is open, and fixed the alignment for CartItem.

volodymyr-soltys97
volodymyr-soltys97 suggested changes Aug 27, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done!
To improve:
It is necessary to remove the limitation of the maximum quantity of 10 units, the user must choose the quantity he needs, even if it is more than 10
image

@SrTrace
Copy link
Author

SrTrace commented Aug 27, 2024

The limit on the quantity of items in the cart has been fixed.

volodymyr-soltys97
volodymyr-soltys97 approved these changes Aug 27, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volodymyr-soltys97 volodymyr-soltys97 volodymyr-soltys97 approved these changes

@SanyaBratashchuk SanyaBratashchuk Awaiting requested review from SanyaBratashchuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SrTrace @volodymyr-soltys97 @SanyaBratashchuk