Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

just save #495

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

just save #495

wants to merge 30 commits into from

Conversation

Annbpiu
Copy link

@Annbpiu Annbpiu commented Sep 3, 2024

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to deploy your solution and provide a link in the PR description

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Screenshot 2024-09-26 at 14 17 12
Products added from different pages have different styles
Screenshot 2024-09-26 at 14 16 36
The button doesn't change after the click
Screenshot 2024-09-26 at 14 16 06
Check the actual quantity and quantity on carts label

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Screenshot 2024-09-26 at 15 33 36
Consider adding a link to the GH and info about you
Screenshot 2024-09-26 at 15 33 23
Check styles for mobiles
Screenshot 2024-09-26 at 15 32 52

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, except for the number of products
Screenshot 2024-09-26 at 17 29 12

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has started work on add, but the quantity after deletion doesn't work as expected
Screenshot 2024-09-26 at 17 53 59

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. should not be white colors here (create the object with colors and reuse it here)
const COLORS = {
 sierraBlue: '#smth',
 ..........
}
image
  1. can see the 404 page on page reloading
Screen.Recording.2024-09-27.at.10.06.07.mov
  1. looks like this scroll is redundant in this case
Screen.Recording.2024-09-27.at.10.07.57.mov
  1. button looks like disabled, change their styles a little bit
image

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
The footer should be at the bottom even if there are no content
Screenshot 2024-09-27 at 15 36 38

@Annbpiu
Copy link
Author

Annbpiu commented Sep 27, 2024

Great work! The footer should be at the bottom even if there are no content Screenshot 2024-09-27 at 15 36 38

let me cry ='(

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants