Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

develop #496

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

develop #496

wants to merge 7 commits into from

Conversation

Prokopovych16
Copy link

No description provided.

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to deploy your page and provide a link in the PR description

@Prokopovych16
Copy link
Author

Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.
Needs some improvements.

  • pagination for all items looks a little unexpected
    Screenshot 2024-09-11 at 22 26 55
  • set 1 page after change itemsPerPage to avoid such view in the page
    Screenshot 2024-09-11 at 22 25 50
    Screenshot 2024-09-11 at 22 28 12
  • make gaps between pagination buttons
    Screenshot 2024-09-11 at 22 25 31

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
To improve:

  1. Add a favicon on the page
image
  1. Links in the header should stretch to the entire height of the header so that it is convenient to click
image
  1. When we increase or decrease goods, then
    the total must be updated everywhere
image image image
  1. Need to centered these buttons
image
  1. Add transition when this menu appears on the page
image

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done!
To improve:

  1. This comment still not fixed from the previous review
image image image
  1. Also, this comment still not fixed
image

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done!
To improve:

  1. Where is the close menu icon?
image
  1. Slider isn't working on the mobile version, I can't change image
image

@Prokopovych16
Copy link
Author

Screenshot 2024-09-14 at 19 28 49

the button works on my device

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants