Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phone catalog #497

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Phone catalog #497

wants to merge 27 commits into from

Conversation

Galers
Copy link

@Galers Galers commented Sep 6, 2024

Have a nice day!😊😊😊
DEMO LINK

SanyaBratashchuk
SanyaBratashchuk suggested changes Sep 7, 2024
View reviewed changes
Copy link

@SanyaBratashchuk SanyaBratashchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demo link is broken
image

volodymyr-soltys97
volodymyr-soltys97 suggested changes Sep 9, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
To improve:

  1. Add a favicon on the page
image
  1. Remove scroll when the basket is empty
image
  1. Fix the mobile and tablet versions
image image

etojeDenys
etojeDenys suggested changes Sep 13, 2024
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this select doesn't work
image

search too
image

  1. display in favorite pages cards with selected heart
image
  1. I cannot open the items from cart page
image
Screen.Recording.2024-09-13.at.09.43.53.mov

SanyaBratashchuk
SanyaBratashchuk suggested changes Oct 17, 2024
View reviewed changes
Copy link

@SanyaBratashchuk SanyaBratashchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanyaBratashchuk SanyaBratashchuk SanyaBratashchuk approved these changes

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

@etojeDenys etojeDenys Awaiting requested review from etojeDenys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Galers @volodymyr-soltys97 @etojeDenys @SanyaBratashchuk