Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project completed #499

Open
wants to merge 445 commits into
base: master
Choose a base branch
from
Open

Project completed #499

wants to merge 445 commits into from

Conversation

meljaszuk
Copy link

Hi,
I have completed the project. I would appreciate your feedback.

Links

  • FIGMA: View the Figma design for the project.
  • DEMO: Check out the live demo of the phone catalog.

Copy link

@Zibi95 Zibi95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have noticed that when the image is scaled up in detail, the border disappears.

Screen.Recording.2024-09-13.at.19.21.47.mov

The links in the footer aren't working as expected—they are appending my GitHub profile link to the existing links. Additionally, the back button doesn't seem to function correctly on the 404 page.

@meljaszuk
Copy link
Author

All issues fixed :)

Links

Copy link

@Zibi95 Zibi95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like that's it! LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants