-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copied from my project into this directory #500
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you created a copy to add it to the portfolio? In this case, you shouldn't fork it from mate-academy repository (there is a special task for it on the platform). Also, the fork doesn't make sense since you actually use a completely new code. So commands (scripts) in package.json now doesn't work properly (they try to work with mate-academy scripts). So you have to fix this part :) |
I've asked what to do in the situation like that, when I've created a project from scratch, but still want to get a review from a mentors and get a task completed on a platform and got a reply, that I need to copy it to a fork. |
Also, there is a bug:
Solution: set the first page when changing items/page. Make the message text bigger and (maybe) center it. |
Got it now, thank you. Generally, you did everything right in this case) It would be nice to add such a comment in PR description at the very beginning so any mentor who's reviewing the task knows it. But thanks for the fast response 👍 So the previous comment is still relevant: delete redundant dependencies (mate-scripts for example). I see you've added eslint, so add commend to run lint. Same for other instruments if there is something else. Usually, this task review mostly means testing your deployed solution. Add comment if you want more detailed code review 🙂 For now - fix current issues) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check comments
will fix everything tomorrow and will make a re-request, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, The link is currently not working
It should be possible to check the demo without authorization, since in the future companies will look at the demo, it should be done as conveniently as possible and without additional authorizations
If you need help with github pages deployment feel free in the fe_chat
Had a lot of problems with deploying the page, but now all the urls / file paths are fixed, so should be available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! 🔥
Preview