Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copied from my project into this directory #500

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

mykhailonl
Copy link

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, you need to add the demo link from readme.md file to the PR description
image

@mykhailonl
Copy link
Author

mykhailonl commented Sep 11, 2024

DEMO LINK

@TarasHoliuk
Copy link

So you created a copy to add it to the portfolio? In this case, you shouldn't fork it from mate-academy repository (there is a special task for it on the platform). Also, the fork doesn't make sense since you actually use a completely new code. So commands (scripts) in package.json now doesn't work properly (they try to work with mate-academy scripts). So you have to fix this part :)

@mykhailonl
Copy link
Author

So you created a copy to add it to the portfolio? In this case, you shouldn't fork it from mate-academy repository (there is a special task for it on the platform). Also, the fork doesn't make sense since you actually use a completely new code. So commands (scripts) in package.json now doesn't work properly (they try to work with mate-academy scripts). So you have to fix this part :)

I've asked what to do in the situation like that, when I've created a project from scratch, but still want to get a review from a mentors and get a task completed on a platform and got a reply, that I need to copy it to a fork.
What do I need to do in that case? :)

@TarasHoliuk
Copy link

  1. Add cursor: pointer to all interactive elements:
    image

  2. The footer always should be at the bottom of the page:
    image

Also, there is a bug:

  • select 4 items/page
  • select the last (or in the second part of pagination) page
  • select 16 items/page
  • observe no products displayed

Solution: set the first page when changing items/page.

  1. This button leads to 404 page - fix it (make it anchor link or better just duplicate gitHub link):
    image

  2. Cursor pointer for buttons:
    image

  3. Empty Favorites (and Cart) page doesn't look good:
    image

Make the message text bigger and (maybe) center it.

@TarasHoliuk
Copy link

I've asked what to do in the situation like that, when I've created a project from scratch, but still want to get a review from a mentors and get a task completed on a platform and got a reply, that I need to copy it to a fork.
What do I need to do in that case? :)

Got it now, thank you. Generally, you did everything right in this case) It would be nice to add such a comment in PR description at the very beginning so any mentor who's reviewing the task knows it. But thanks for the fast response 👍

So the previous comment is still relevant: delete redundant dependencies (mate-scripts for example). I see you've added eslint, so add commend to run lint. Same for other instruments if there is something else.

Usually, this task review mostly means testing your deployed solution. Add comment if you want more detailed code review 🙂 For now - fix current issues)

TarasHoliuk

This comment was marked as duplicate.

Copy link

@TarasHoliuk TarasHoliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check comments

@mykhailonl
Copy link
Author

Check comments

will fix everything tomorrow and will make a re-request, thanks!

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
To improve:

  1. This block in the basket must be on the same line, fix it
image
  1. Add hover effects here
image

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done!
Sometimes this error occurs on Vercel, use better github pages for deployment demo link
image

@mykhailonl
Copy link
Author

Almost done! Sometimes this error occurs on Vercel, use better github pages for deployment demo link image

really struggling with deployment at pages, heres a last link to vercel, also you can click Production at my repo deployments

DEMO VERCEL
GITHUB REPO

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, The link is currently not working
image

It should be possible to check the demo without authorization, since in the future companies will look at the demo, it should be done as conveniently as possible and without additional authorizations
image

If you need help with github pages deployment feel free in the fe_chat

@mykhailonl
Copy link
Author

Had a lot of problems with deploying the page, but now all the urls / file paths are fixed, so should be available.
DEMO

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants