Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #501

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Solution #501

wants to merge 22 commits into from

Conversation

Oleksii-Bidiak
Copy link

anastasiiavorobiova
anastasiiavorobiova suggested changes Sep 11, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Screenshot 2024-09-11 at 17 21 07
The item should be removed from the favourites if a user clicks on nthe heart
Screenshot 2024-09-11 at 17 20 44
Check the quantity here

@TarasHoliuk
Copy link

  1. Number in the header still doesn't match number on the cart page:

image

  1. Great job with pagination + search or items/page select. But observed a strange bug:
REC-20240911192946.mp4

TarasHoliuk
TarasHoliuk suggested changes Sep 11, 2024
View reviewed changes
Copy link

@TarasHoliuk TarasHoliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🔥 2 more comments to make it even better

volodymyr-soltys97
volodymyr-soltys97 suggested changes Sep 12, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
To improve:

  1. Remove the scroll when the basket is empty
image
  1. Fix this error after clicking on contacts and rights in the footer
image image

volodymyr-soltys97
volodymyr-soltys97 suggested changes Sep 12, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done!
These elements must be links, add the your github profile link here and cursor pointer here
image

anastasiiavorobiova
anastasiiavorobiova suggested changes Sep 12, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! The last page should be also highlighted
Screenshot 2024-09-12 at 15 28 02

anastasiiavorobiova
anastasiiavorobiova approved these changes Sep 12, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anastasiiavorobiova anastasiiavorobiova anastasiiavorobiova approved these changes

@TarasHoliuk TarasHoliuk Awaiting requested review from TarasHoliuk

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Oleksii-Bidiak @TarasHoliuk @volodymyr-soltys97 @anastasiiavorobiova