add task solution #1514
Open
add task solution #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volodymyr-soltys97
suggested changes
Nov 12, 2024
src/components/TodoList.tsx
Outdated
Comment on lines
59
to
86
| return ( | ||
| <div | ||
| data-cy="Todo" | ||
| className={classNames('todo', { completed: completed })} | ||
| key={id} | ||
| > | ||
| <label className="todo__status-label"> | ||
| <input | ||
| data-cy="TodoStatus" | ||
| type="checkbox" | ||
| className="todo__status" | ||
| checked={completed} | ||
| onClick={() => { | ||
| changeTodo({ ...todo, completed: !completed }); | ||
| setUpdatingAndDeletingCompletedTodos([todo]); | ||
| }} | ||
| /> | ||
| </label> | ||
|
|
||
| {editingTitle === id ? ( | ||
| <FormEditingTitle | ||
| todo={todo} | ||
| titleEdit={titleEdit} | ||
| setTitleEdit={setTitleEdit} | ||
| handleChangeSubmit={handleChangeSubmit} | ||
| setEditingTitle={setEditingTitle} | ||
| /> | ||
| ) : ( |
There was a problem hiding this comment.
Move this logic to the TodoItem component
src/components/TodoList.tsx
Outdated
Comment on lines
132
to
159
| <div data-cy="Todo" className="todo"> | ||
| <label className="todo__status-label"> | ||
| <input | ||
| data-cy="TodoStatus" | ||
| type="checkbox" | ||
| className="todo__status" | ||
| /> | ||
| </label> | ||
|
|
||
| <span data-cy="TodoTitle" className="todo__title"> | ||
| {tempTodo} | ||
| </span> | ||
|
|
||
| {/* Remove button appears only on hover */} | ||
| <button type="button" className="todo__remove" data-cy="TodoDelete"> | ||
| x | ||
| </button> | ||
|
|
||
| {/* overlay will cover the todo while it is being deleted or updated */} | ||
| <div data-cy="TodoLoader" className="modal overlay is-active"> | ||
| <div | ||
| className={classNames( | ||
| 'modal-background', | ||
| 'has-background-white-ter', | ||
| )} | ||
| /> | ||
| <div className="loader" /> | ||
| </div> |
There was a problem hiding this comment.
Move these logic to the separate component
SanyaBratashchuk
approved these changes
Nov 12, 2024
| ); | ||
| })} | ||
|
|
||
| {tempTodo && <TempTodoItem tempTodo={tempTodo} />} |
There was a problem hiding this comment.
u can use TodoItem component here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://VictorKomara.github.io/react_todo-app-with-api/