Port to libsoup-3.0 #133
Open
Port to libsoup-3.0 #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgn
force-pushed
the
libsoup-3.0
branch
3 times, most recently
from
b1fe9cb
to
2263bc6
Compare
lukefromdc
approved these changes
Mar 6, 2024
|
One possible issue here: we just released 1.28 and probably cannot change external dependencies like this within 1.28 and thus probably cannot do this without bumping version to 1.29 |
sgn
commented
Mar 8, 2024
Comment on lines
-351
to
360
| void request_done (WeatherInfo *info, gboolean ok) | ||
| void request_done (WeatherInfo *info, GError *error) | ||
| { | ||
| if (ok) { | ||
| if (error == NULL) { | ||
| (void) calc_sun (info); | ||
| info->moonValid = info->valid && calc_moon (info); | ||
| } | ||
| } else if (error->code == G_IO_ERROR_CANCELLED) | ||
| return; /* Caused by soup_session_abort */ | ||
| if (!--info->requests_pending) | ||
| info->finish_cb (info, info->cb_data); | ||
| } |
There was a problem hiding this comment.
Hello, this PR also fixes a heap-use-after-free in current code base.
Step to reprocedure:
- Enable weather applets (from mate-applets repository)
- Switch to Location tab
- Quickly find and switch multiple Location by Find textbox (e.g. type Paris, London, Ho Chi Minh).
- It will crash
Analysis:
- On quick Location find and switch, the request will be sent and freed (with
weather_info_free) continously. weather_info_freewill callweather_info_abortwhich, in turn, callssoup_session_abort.- soup_session_abort will invoke their callback before returning. However, the document is unclear whether its callback has finished or not at the time of returning. In reality, it's not.
- Later in
weather_info_free, theWeatherInfostructure will be freed. - In the racy case, after
WeatherInfofreed (inweather_info_free), it could be used, either byrequest_doneorinfo->network_errorin metar.c
Fixes:
- Fix for
libsoup-2.4: I can't think of a reliable way (honestly, I don't care that much about a fix forlibsoup-2.4) - Fix for
libsoup-3.0: Not touchingWeatherInfoif the request was cancalled, as indicated by the error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.