Skip to content

Commit

Permalink
chore: refactor iconbutton focus ring
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 563397006
  • Loading branch information
material-web-copybara authored and copybara-github committed Sep 18, 2023
1 parent 205b20b commit 2387a63
Showing 1 changed file with 39 additions and 7 deletions.
46 changes: 39 additions & 7 deletions packages/mdc-icon-button/_icon-button-theme.scss
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ $light-theme: (
pressed-state-layer-color: theme-color.$primary,
pressed-state-layer-opacity: 0.12,
state-layer-size: $size,
focus-ring-color: null,
focus-ring-offset: 0,
);

@mixin theme($theme) {
Expand Down Expand Up @@ -118,6 +120,9 @@ $light-theme: (
),
$ripple-target: $ripple-target
);

@include _focus-ring-color(map.get($theme, 'focus-ring-color'));
@include _focus-ring-offset(map.get($theme, 'focus-ring-offset'));
}

///
Expand Down Expand Up @@ -151,13 +156,6 @@ $light-theme: (
padding: calc(($size - $icon-size) / 2);
}

.mdc-icon-button__focus-ring {
@include feature-targeting.targets($feat-structure) {
max-height: $size;
max-width: $size;
}
}

&.mdc-icon-button--reduced-size {
$component-size: $size;
// Icon button ripple size is capped at 40px for icon buttons with
Expand Down Expand Up @@ -392,6 +390,40 @@ $light-theme: (
}
}

@mixin _focus-ring-color($color, $query: feature-targeting.all()) {
$color-value: if(
custom-properties.is-custom-prop($color),
custom-properties.get-declaration-value($color),
$color
);

@if $color != null {
.mdc-icon-button__focus-ring {
@include focus-ring.focus-ring-color(
$inner-ring-color: $color-value,
$query: $query
);
}
}
}

@mixin _focus-ring-offset($offset, $query: feature-targeting.all()) {
$offset-value: if(
custom-properties.is-custom-prop($offset),
custom-properties.get-declaration-value($offset),
$offset
);

@if type-of($offset-value) == 'number' {
.mdc-icon-button__focus-ring {
@include focus-ring.focus-ring-offset(
$offset: $offset-value,
$query: $query
);
}
}
}

///
/// Helps style the icon button in its disabled state.
/// @access private
Expand Down

0 comments on commit 2387a63

Please sign in to comment.