fix default bands color specification

materialscloud-org · Apr 10, 2024 · 6bb0c59 · 6bb0c59
1 parent 57924fc
commit 6bb0c59
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/src/App.jsx b/src/App.jsx
@@ -81,6 +81,7 @@ function App() {
         <BandsVisualizer
           bandsDataList={[si_bands]}
           energyRange={[-10.0, 10.0]}
+          bandsColorInfo={["red"]}
         />
       </div>
     </div>

diff --git a/src/lib/jqueryBands/bands.js b/src/lib/jqueryBands/bands.js
@@ -100,7 +100,7 @@ function bandPlot(
 
       if (colorInfo !== undefined) {
         if (typeof colorInfo[dataIdx] === "object") {
-          var newColor = tinycolor("red");
+          var newColor = tinycolor("black");
           colorDict = [newColor, colorInfo[dataIdx][0], colorInfo[dataIdx][1]];
         } else if (typeof colorInfo[dataIdx] === "string") {
           var newColor = tinycolor(colorInfo[dataIdx]);
@@ -110,8 +110,8 @@ function bandPlot(
             newColor.brighten(20).toHexString(),
           ];
         } else {
-          // default bandstructure color is red
-          var newColor = tinycolor("red");
+          // default bandstructure color is black
+          var newColor = tinycolor("black");
           colorDict = [
             newColor.toHexString(),
             newColor.darken(20).toHexString(),

diff --git a/src/lib/jqueryBands/bandstructure.js b/src/lib/jqueryBands/bandstructure.js
@@ -181,7 +181,7 @@ BandPlot.prototype.addBandStructure = function (bandsData, colorInfo) {
     "#ff7f00",
   ];
 
-  if (!colorInfo || colorInfo.length) {
+  if (!colorInfo) {
     var nextIndex = this.allColorInfo.length;
     var newColor = tinycolor(defaultColors[nextIndex % defaultColors.length]);
     colorInfo = [