Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider-agnostic jsonl file? #44

Open
eimrek opened this issue Jan 11, 2024 · 1 comment
Open

Provider-agnostic jsonl file? #44

eimrek opened this issue Jan 11, 2024 · 1 comment

Comments

@eimrek
Copy link
Member

eimrek commented Jan 11, 2024

Currently, when generating the OPTIMADE jsonl file, custom/provider properties automatically get the mcloudarchive prefix by default, or a different prefix if changed via the MC_OPTIMADE_PROVIDER_PREFIX env variable.

I am still thinking whether it might make sense to keep jsonl file provider-agnostic (e.g. using a placeholder prefix like _custom or _provider). Possible reasons:

  • you don't need to know the provider when generating the jsonl file.
  • cleaner to serve the same jsonl from different providers.
  • easier to distinguish between provider vs the future namespace prefixes (e.g. is _stability a provider?)

Although I understand that there is value in having the jsonl file exactly mirror the underlying data (mongoDB in our case) and the API responses. So actually, maybe it's good to keep it as it is now.

thoughts, @ml-evs?

@eimrek
Copy link
Member Author

eimrek commented Jul 3, 2024

Just to document here: one possible idea we discussed during the optimade workshop is to use the _optimake prefix for all custom properties in jsonl files made by optimake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant