Fix vasp tests #274
Merged
Fix vasp tests #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, tests are written in a way that if a failure happens in the middle of the tests the
test_fileswould be left in an inconsistent state.This PR quickly fixes the tests that seem to show those potential issues for VASP tests, but I believe that the same may happen for other codes as well, as I have found some modified cp2k test in my folder after running all the tests.
However it seems that a safer solution would be to rely on temporary folders, rather than copying files back and forth in the
test_filesfolder.