Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this should not be typescript #2

Open
laenNoCode opened this issue May 21, 2020 · 1 comment
Open

this should not be typescript #2

laenNoCode opened this issue May 21, 2020 · 1 comment

Comments

@laenNoCode
Copy link

you should not switch a project called jstetris to typescript. you should either do a new branch or a new project (called tsTetris)

  • your code is dirty.
@mathieucaroff
Copy link
Owner

  • Regarding the name of the project, there are other project which followed a similar path of starting as a JS project, and then becoming TS, while keeping JS in their name. For instance, AdonisJS.

  • Regarding the dirtiness of the code, please be more specific and provide examples from the codebase (please provide both a code block and a future-proof link to the file).

I'm aware of a number of issues with the code, but I don't have any need to fix them as long as I don't intend to develop the game more. If anybody wants to work with the jsTetris codebase and needs to fix some of these issues through large refactors, I'm open to PR from them. Note that it may be opportune to first open an issue and discuss it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants