Improve HTTP Client structure

mathleite · Mar 27, 2020 · f57be43 · f57be43
1 parent 590fb49
commit f57be43
Show file tree

Hide file tree

Showing 7 changed files with 25 additions and 22 deletions.
diff --git a/app/Notification/AppNotificationInterface.php b/app/Notification/AppNotificationInterface.php
@@ -5,11 +5,11 @@
 
 
 use App\Notification\Client\HTTPClientAdapterInterface;
-use App\Notification\Client\ResponseAdapterInterface;
+use App\Notification\Client\HTTPResponseInterface;
 
 interface AppNotificationInterface
 {
     public function __construct(HTTPClientAdapterInterface $client, string $message, string $messageType);
 
-    public function notify(): ResponseAdapterInterface;
+    public function notify(): HTTPResponseInterface;
 }
diff --git a/app/Notification/Client/Guzzle/GuzzleHTTPClient.php b/app/Notification/Client/Guzzle/GuzzleHTTPClient.php
@@ -5,9 +5,8 @@
 
 
 use App\Notification\Client\HTTPClientAdapterInterface;
-use App\Notification\Client\ResponseAdapterInterface;
+use App\Notification\Client\HTTPResponseInterface;
 use GuzzleHttp\Client;
-use Psr\Http\Message\ResponseInterface;
 
 class GuzzleHTTPClient implements HTTPClientAdapterInterface
 {
@@ -18,15 +17,15 @@ public function __construct()
         $this->client = new Client();
     }
 
-    public function post(string $url, array $params): ResponseAdapterInterface
+    public function post(string $url, array $params): HTTPResponseInterface
     {
-        $clientResponse = $this->client->post(
+        $guzzleResponse = $this->client->post(
             $url,
             [
                 'json' => $params
             ]
         );
 
-        return new GuzzleResponse($clientResponse);
+        return new HTTPResponse($guzzleResponse);
     }
 }
diff --git a/...fication/Client/Guzzle/GuzzleResponse.php → ...tification/Client/Guzzle/HTTPResponse.php b/...fication/Client/Guzzle/GuzzleResponse.php → ...tification/Client/Guzzle/HTTPResponse.php
@@ -4,10 +4,10 @@
 namespace App\Notification\Client\Guzzle;
 
 
-use App\Notification\Client\ResponseAdapterInterface;
+use App\Notification\Client\HTTPResponseInterface;
 use Psr\Http\Message\ResponseInterface;
 
-class GuzzleResponse implements ResponseAdapterInterface
+class HTTPResponse implements HTTPResponseInterface
 {
     private ResponseInterface $clientResponse;
 

diff --git a/app/Notification/Client/HTTPClientAdapterInterface.php b/app/Notification/Client/HTTPClientAdapterInterface.php
@@ -6,5 +6,5 @@
 
 interface HTTPClientAdapterInterface
 {
-    public function post(string $url, array $params): ResponseAdapterInterface;
+    public function post(string $url, array $params): HTTPResponseInterface;
 }
diff --git a/app/Notification/Client/HTTPResponseInterface.php b/app/Notification/Client/HTTPResponseInterface.php
@@ -0,0 +1,14 @@
+<?php
+
+
+namespace App\Notification\Client;
+
+
+use Psr\Http\Message\ResponseInterface;
+
+interface HTTPResponseInterface
+{
+    public function __construct(ResponseInterface $clientResponse);
+
+    public function getResponse(): array;
+}
diff --git a/app/Notification/Client/ResponseAdapterInterface.php b/app/Notification/Client/ResponseAdapterInterface.php
diff --git a/app/Notification/Slack/SlackNotification.php b/app/Notification/Slack/SlackNotification.php
@@ -6,7 +6,7 @@
 
 use App\Notification\AppNotificationInterface;
 use App\Notification\Client\HTTPClientAdapterInterface;
-use App\Notification\Client\ResponseAdapterInterface;
+use App\Notification\Client\HTTPResponseInterface;
 
 final class SlackNotification implements AppNotificationInterface
 {
@@ -19,7 +19,7 @@ public function __construct(HTTPClientAdapterInterface $client, string $message,
         $this->client  = $client;
     }
 
-    public function notify(): ResponseAdapterInterface
+    public function notify(): HTTPResponseInterface
     {
         return $this->client->post(
             getenv('SLACK_API_WEBHOOK'),