Skip to content

Commit

Permalink
code-tidy - Minor tweaks
Browse files Browse the repository at this point in the history
  • Loading branch information
EJMFarrow committed Dec 18, 2024
1 parent 64d326c commit 868c615
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 19 deletions.
15 changes: 4 additions & 11 deletions stack/input/factory.class.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,11 @@
// along with Stack. If not, see <http://www.gnu.org/licenses/>.

/**
* Add description here!
* Input factory.
* Provides a convenient way to create an input of any type,
* and to get metadata about the input types.
* @package qtype_stack
* @copyright 2024 University of Edinburgh.
* @copyright 2012 University of Birmingham.
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later.
*/

Expand All @@ -26,15 +28,6 @@
require_once(__DIR__ . '/../options.class.php');
require_once(__DIR__ . '/inputbase.class.php');

/**
* Input factory. Provides a convenient way to create an input of any type,
* and to get metadata about the input types.
*
* @package qtype_stack
* @copyright 2012 University of Birmingham.
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later.
*/

// phpcs:ignore moodle.Commenting.MissingDocblock.Class
class stack_input_factory {
/**
Expand Down
5 changes: 1 addition & 4 deletions stack/input/inputbase.class.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
/**
* Add description here!
* @package qtype_stack
* @copyright 2024 University of Edinburgh.
* @copyright 2012 University of Birmingham
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later.
*/

Expand All @@ -34,9 +34,6 @@
* Inputs are the controls that the teacher can put into the question
* text to receive the student's response.
*
* @package qtype_stack
* @copyright 2012 University of Birmingham
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
abstract class stack_input {
// phpcs:ignore moodle.Commenting.MissingDocblock.Constant
Expand Down
9 changes: 5 additions & 4 deletions tests/caskeyval_test.php
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,11 @@ public function test_empty_case_1(): void {
$this->assertTrue($at1->get_valid());
}

// Now here we have a problem, keyvals do not generate output values
// they just load stuff to the session, therefore you cannot get
// the instantiated values.
// phpcs:ignore moodle.Commenting.MissingDocblock.Function
/**
* Now here we have a problem, keyvals do not generate output values
* they just load stuff to the session, therefore you cannot get
* the instantiated values.
*/
public function test_equations_1(): void {

$at1 = new stack_cas_keyval('ta1 : x=1; ta2 : x^2-2*x=1; ta3:x=1 nounor x=2', null, 123);
Expand Down

0 comments on commit 868c615

Please sign in to comment.