From 868c615c1db9b7e0d3f1a01481750c305ddbf855 Mon Sep 17 00:00:00 2001 From: Edmund Farrow Date: Wed, 18 Dec 2024 10:13:42 +0000 Subject: [PATCH] code-tidy - Minor tweaks --- stack/input/factory.class.php | 15 ++++----------- stack/input/inputbase.class.php | 5 +---- tests/caskeyval_test.php | 9 +++++---- 3 files changed, 10 insertions(+), 19 deletions(-) diff --git a/stack/input/factory.class.php b/stack/input/factory.class.php index 7b95ea30ec..18ace7295d 100644 --- a/stack/input/factory.class.php +++ b/stack/input/factory.class.php @@ -15,9 +15,11 @@ // along with Stack. If not, see . /** - * Add description here! + * Input factory. + * Provides a convenient way to create an input of any type, + * and to get metadata about the input types. * @package qtype_stack - * @copyright 2024 University of Edinburgh. + * @copyright 2012 University of Birmingham. * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later. */ @@ -26,15 +28,6 @@ require_once(__DIR__ . '/../options.class.php'); require_once(__DIR__ . '/inputbase.class.php'); -/** - * Input factory. Provides a convenient way to create an input of any type, - * and to get metadata about the input types. - * - * @package qtype_stack - * @copyright 2012 University of Birmingham. - * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later. - */ - // phpcs:ignore moodle.Commenting.MissingDocblock.Class class stack_input_factory { /** diff --git a/stack/input/inputbase.class.php b/stack/input/inputbase.class.php index 8bbe7e9b4b..75f5ceaf90 100644 --- a/stack/input/inputbase.class.php +++ b/stack/input/inputbase.class.php @@ -17,7 +17,7 @@ /** * Add description here! * @package qtype_stack - * @copyright 2024 University of Edinburgh. + * @copyright 2012 University of Birmingham * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later. */ @@ -34,9 +34,6 @@ * Inputs are the controls that the teacher can put into the question * text to receive the student's response. * - * @package qtype_stack - * @copyright 2012 University of Birmingham - * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later */ abstract class stack_input { // phpcs:ignore moodle.Commenting.MissingDocblock.Constant diff --git a/tests/caskeyval_test.php b/tests/caskeyval_test.php index 4a9d4ec860..85289e7913 100644 --- a/tests/caskeyval_test.php +++ b/tests/caskeyval_test.php @@ -105,10 +105,11 @@ public function test_empty_case_1(): void { $this->assertTrue($at1->get_valid()); } - // Now here we have a problem, keyvals do not generate output values - // they just load stuff to the session, therefore you cannot get - // the instantiated values. - // phpcs:ignore moodle.Commenting.MissingDocblock.Function + /** + * Now here we have a problem, keyvals do not generate output values + * they just load stuff to the session, therefore you cannot get + * the instantiated values. + */ public function test_equations_1(): void { $at1 = new stack_cas_keyval('ta1 : x=1; ta2 : x^2-2*x=1; ta3:x=1 nounor x=2', null, 123);