Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable monitor interactive paging on windows #269 #271

Merged

Conversation

haristku
Copy link
Contributor

@haristku haristku commented Oct 22, 2024

Description:

disable monitor interactive paging on Windows environment
Fixes: #269

this PR will cause the monitor feature to have different behaviour between Windows and Linux.
please advise, are these different conditions allowed or not? if not allowed, i will adjust the code to remove the interactive paging feature altogether.


  • the new -r parameter replace the old -p
  • while -p now used to jump to specific page

for example (if we have 16 queue workers):

  • php console queuedtracking:monitor will display 16 rows per page (only 1 page)
  • php console queuedtracking:monitor -r 3 will display 3 rows per page (6 pages total)
  • php console queuedtracking:monitor -r 3 -p 2 will display 3 rows per page and jump to 2nd page
  • php console queuedtracking:monitor -r 3 -p 6 will display 3 rows per page and jump to 6th page

-r and -p will work both on Windows or Linux, but only Linux has the ability to move pages interactively.

@AltamashShaikh @snake14 do you have any other suggestions?

@haristku haristku changed the title disable monitor interactive paging on windows disable monitor interactive paging on windows #269 Oct 22, 2024
Copy link
Contributor

@AltamashShaikh AltamashShaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haristku Requested 1 change rest looks good to me 👍

Co-authored-by: Altamash Shaikh <altu9594@gmail.com>
@haristku
Copy link
Contributor Author

done.. 👍
ty.

Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I didn't find any issues in my testing. Nice work! 👍

I didn't see any validation for a page number higher than there are pages, but it simply returns the last page when I tried it. I think that works fine.

@AltamashShaikh AltamashShaikh merged commit ff5b947 into matomo-org:5.x-dev Oct 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal queuedtracking:monitor issue
3 participants