Skip to content

Commit

Permalink
fix grammer; and add **make_addplot()** to TODO list
Browse files Browse the repository at this point in the history
  • Loading branch information
DanielGoldfarb committed Dec 11, 2021
1 parent 449fe54 commit 28b05ca
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions examples/marketcolor_overrides.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@
"1. It helps ensure that your marketcolor overrides are the same length as your dataframe, and\n",
"2. It allows you to use the dataframe's `DatetimeIndex` in order to position the override values.\n",
"\n",
"#### Note that you will still have to pass the `marketcolor_overrides` as an separate iterable (apart from the dataframe)."
"#### Note that you will still have to pass the `marketcolor_overrides` as a separate iterable (apart from the dataframe)."
]
},
{
Expand Down Expand Up @@ -787,8 +787,9 @@
"source": [
"### TO DO:\n",
"1. `marketcolor_overrides` should affect volume *when the override is a marketcolor object* that includes a 'volume' key.\n",
"2. support \"hollow and filled\" candles.\n",
"3. support renko and point-and-figure. This may be tricky (since one \"box\" may cover more and/or less than one date). Also, is support for marketcolor overrides even needed for renko and pnf? (find out from those who commonly use them)."
"2. support `marketcolor_overrides` in **`mpf.make_addplot()`**\n",
"3. support \"hollow and filled\" candles (both `mpf.plot()` and `mpf.make_addplot()`).\n",
"4. support renko and point-and-figure. This may be tricky (since one \"box\" may cover more and/or less than one date). Also, is support for marketcolor overrides even needed for renko and pnf? (find out from those who commonly use them)."
]
},
{
Expand Down

0 comments on commit 28b05ca

Please sign in to comment.