From 28b05ca247f5557298f0b07e850796dfcdc826b1 Mon Sep 17 00:00:00 2001 From: Daniel Goldfarb Date: Sat, 11 Dec 2021 18:33:10 -0500 Subject: [PATCH] fix grammer; and add **`make_addplot()`** to TODO list --- examples/marketcolor_overrides.ipynb | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/examples/marketcolor_overrides.ipynb b/examples/marketcolor_overrides.ipynb index b58596d8..e4968366 100644 --- a/examples/marketcolor_overrides.ipynb +++ b/examples/marketcolor_overrides.ipynb @@ -357,7 +357,7 @@ "1. It helps ensure that your marketcolor overrides are the same length as your dataframe, and\n", "2. It allows you to use the dataframe's `DatetimeIndex` in order to position the override values.\n", "\n", - "#### Note that you will still have to pass the `marketcolor_overrides` as an separate iterable (apart from the dataframe)." + "#### Note that you will still have to pass the `marketcolor_overrides` as a separate iterable (apart from the dataframe)." ] }, { @@ -787,8 +787,9 @@ "source": [ "### TO DO:\n", "1. `marketcolor_overrides` should affect volume *when the override is a marketcolor object* that includes a 'volume' key.\n", - "2. support \"hollow and filled\" candles.\n", - "3. support renko and point-and-figure. This may be tricky (since one \"box\" may cover more and/or less than one date). Also, is support for marketcolor overrides even needed for renko and pnf? (find out from those who commonly use them)." + "2. support `marketcolor_overrides` in **`mpf.make_addplot()`**\n", + "3. support \"hollow and filled\" candles (both `mpf.plot()` and `mpf.make_addplot()`).\n", + "4. support renko and point-and-figure. This may be tricky (since one \"box\" may cover more and/or less than one date). Also, is support for marketcolor overrides even needed for renko and pnf? (find out from those who commonly use them)." ] }, {