Avoid loops by setting end to an empty string if start == end (#3146)

matrix-org · Jul 8, 2023 · 69b2069 · 69b2069
1 parent b965a08
commit 69b2069
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/syncapi/routing/messages.go b/syncapi/routing/messages.go
@@ -250,6 +250,12 @@ func OnIncomingMessagesRequest(
 		}
 	}
 
+	// If start and end are equal, we either reached the beginning or something else
+	// is wrong. To avoid endless loops from clients, set end to 0 an empty string
+	if start == end {
+		end = types.TopologyToken{}
+	}
+
 	util.GetLogger(req.Context()).WithFields(logrus.Fields{
 		"from":         from.String(),
 		"to":           to.String(),