Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

Commit

Permalink
Update changelog
Browse files Browse the repository at this point in the history
  • Loading branch information
S7evinK committed Jul 6, 2023
1 parent 679817f commit e649367
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,11 @@

This releases fixes a long-standing "off-by-one" error which could result in state resets. Upgrading to this version is **highly** recommended.

When storing state events, we were checking if the event in question was already in something we call a "state snapshot". If it was in a previous state snapshot, we would
When deduplicating state events, we were checking if the event in question was already in a state snapshot. If it was in a previous state snapshot, we would
then remove it from the list of events to store. If this happened, we were, unfortunately, skipping the next event to check. This resulted in
events getting stored in state snapshots where they may not be needed. When we now compared two of those state snapshots, one of them
contained the skipped event, while the other didn't. So there was a difference between them which possibly shouldn't exist, resulting in unexpected state resets.
contained the skipped event, while the other didn't. This difference possibly shouldn't exist, resulting in unexpected state resets.
This also explains reports of rooms missing state events.

This has been fixed - rooms where a state reset occurred earlier should, hopefully, reconcile over time.

Expand Down

0 comments on commit e649367

Please sign in to comment.