Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

Fix setting displayname and avatar_url #3125

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Jun 28, 2023

As per the spec, displayname and avatar_url may be empty.

@S7evinK S7evinK added C-Client-API T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. labels Jun 28, 2023
@S7evinK S7evinK requested a review from a team as a code owner June 28, 2023 17:39
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (a5ea928) 65.84% compared to head (b2442b9) 65.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3125      +/-   ##
==========================================
- Coverage   65.84%   65.82%   -0.02%     
==========================================
  Files         504      504              
  Lines       55762    55750      -12     
==========================================
- Hits        36716    36698      -18     
- Misses      15282    15284       +2     
- Partials     3764     3768       +4     
Flag Coverage Δ
unittests 49.95% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
clientapi/routing/profile.go 49.06% <ø> (-0.05%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@S7evinK S7evinK merged commit 4722f12 into main Jun 28, 2023
@S7evinK S7evinK deleted the s7evink/fixsettingavatars branch June 28, 2023 18:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C-Client-API T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant