-
-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pseudoIDs] Allow displayname changes, kick users on redaction #3131
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3131 +/- ##
==========================================
- Coverage 64.44% 64.31% -0.14%
==========================================
Files 506 506
Lines 57011 57202 +191
==========================================
+ Hits 36743 36788 +45
- Misses 16442 16576 +134
- Partials 3826 3838 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Not needed anymore, iirc. |
This PR changes a few things to allow displayname/avatar changes in pseudo ID rooms.
GetRoomsByMembership
now queries the pseudo ID keys to get all roomsmxid_mapping
incontent
, the user leaves the room or is kickedcurrent_room_state
(if needed)join
->join
) we now remove themxid_mapping
fromunsigned.prev_content
)join
->join
event and temporarily add a prev_content, so validating the event signature doesn't error because of a missingmxid_mapping
A few things we need to think about:
Considering that users can leave rooms on their own and rejoin them, we now have two join events with a
mxid_mapping
. Currently redacting the current join event results in a leave/kick, but we still have another unredactedmxid_mapping
. It's up to the client to walk theunsigned.replaces_state
field to redact other membership events containing amxid_mapping
Kicking users, on redaction of a join event, may not always be possible, as the powerlevels could have been changed to allow redactions for PL50, but kicking is only allowed for PL100. How do we handle those cases? Temporarily fake/update the powerlevels to allow kicking?