Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

Add event size checks similar to Synapse #3140

Merged
merged 8 commits into from
Jul 7, 2023
Merged

Add event size checks similar to Synapse #3140

merged 8 commits into from
Jul 7, 2023

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Jul 6, 2023

Companion to matrix-org/gomatrixserverlib#400
This tries to mimic the logic found in Synapse, as dropping events can break rooms (and we may end up in endless loops..)

@S7evinK S7evinK added the T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. label Jul 6, 2023
@S7evinK S7evinK requested a review from a team as a code owner July 6, 2023 13:45
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (cc9b695) 65.25% compared to head (ff05a40) 65.26%.

❗ Current head ff05a40 differs from pull request most recent head 772228e. Consider uploading reports for the commit 772228e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3140      +/-   ##
==========================================
+ Coverage   65.25%   65.26%   +0.01%     
==========================================
  Files         504      504              
  Lines       56212    56113      -99     
==========================================
- Hits        36679    36624      -55     
+ Misses      15713    15668      -45     
- Partials     3820     3821       +1     
Flag Coverage Δ
unittests 49.69% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
roomserver/internal/input/input_events.go 56.06% <0.00%> (-2.68%) ⬇️
roomserver/internal/input/input_missing.go 62.67% <0.00%> (-5.51%) ⬇️

... and 31 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@S7evinK S7evinK merged commit eb9e903 into main Jul 7, 2023
@S7evinK S7evinK deleted the s7evink/eventsize branch July 7, 2023 18:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants