Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prev event lookup in syncapi #3141

Merged
merged 2 commits into from
Jul 6, 2023
Merged

Fix prev event lookup in syncapi #3141

merged 2 commits into from
Jul 6, 2023

Conversation

devonh
Copy link
Collaborator

@devonh devonh commented Jul 6, 2023

The syncapi operates using userID's so when querying for the previous state event we need to lookup the userID from the given senderID before the state query.

@devonh devonh requested a review from a team as a code owner July 6, 2023 19:15
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage: 76.92% and project coverage change: +0.02 🎉

Comparison is base (d507c5f) 65.24% compared to head (932a868) 65.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3141      +/-   ##
==========================================
+ Coverage   65.24%   65.26%   +0.02%     
==========================================
  Files         504      504              
  Lines       56210    56210              
==========================================
+ Hits        36673    36686      +13     
+ Misses      15717    15707      -10     
+ Partials     3820     3817       -3     
Flag Coverage Δ
unittests 49.74% <76.92%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
syncapi/consumers/roomserver.go 52.53% <76.92%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@devonh devonh merged commit 3a125fd into main Jul 6, 2023
20 checks passed
@devonh devonh deleted the pseudoid-bugs branch July 6, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants