Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid loops by setting end to an empty string if start == end #3146

Merged
merged 1 commit into from
Jul 8, 2023

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Jul 8, 2023

No description provided.

@S7evinK S7evinK added the T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. label Jul 8, 2023
@S7evinK S7evinK requested a review from a team as a code owner July 8, 2023 09:26
@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (b965a08) 65.28% compared to head (6f4922a) 65.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3146      +/-   ##
==========================================
- Coverage   65.28%   65.26%   -0.03%     
==========================================
  Files         504      504              
  Lines       56297    56300       +3     
==========================================
- Hits        36756    36746      -10     
- Misses      15742    15750       +8     
- Partials     3799     3804       +5     
Flag Coverage Δ
unittests 49.65% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
syncapi/routing/messages.go 66.24% <0.00%> (-0.51%) ⬇️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@S7evinK S7evinK merged commit 69b2069 into main Jul 8, 2023
18 of 20 checks passed
@S7evinK S7evinK deleted the s7evink/messagesloop branch July 8, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant