Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTCSession cleanup: deprecate getKeysForParticipant() and getEncryption(); add emitEncryptionKeys() #4427

Merged
merged 5 commits into from
Sep 27, 2024
Merged

RTCSession cleanup: deprecate getKeysForParticipant() and getEncryption(); add emitEncryptionKeys() #4427

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3bf67d5
RTCSession cleanup: deprecate getKeysForParticipant() and getEncrypti…
hughns Sep 23, 2024
125c2a6
Clarify comment
hughns Sep 23, 2024
e73c660
Feedback from code review
hughns Sep 27, 2024
7f62654
Update src/matrixrtc/MatrixRTCSession.ts
hughns Sep 27, 2024
7740122
Fix test
hughns Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions src/matrixrtc/MatrixRTCSession.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,9 +406,10 @@ export class MatrixRTCSession extends TypedEventEmitter<MatrixRTCSessionEvent, M
}

/**
* Emit an EncryptionKeyChanged event for every tracked encryption keys.
* Re-emit EncryptionKeyChanged events for every tracked encryption keys. This can be used to export
hughns marked this conversation as resolved.
Show resolved Hide resolved
* the keys.
*/
public emitEncryptionKeys(): void {
public reemitEncryptionKeys(): void {
this.encryptionKeys.forEach((keys, participantId) => {
keys.forEach((key, index) => {
this.emit(MatrixRTCSessionEvent.EncryptionKeyChanged, key.key, index, participantId);
Expand Down Expand Up @@ -440,11 +441,6 @@ export class MatrixRTCSession extends TypedEventEmitter<MatrixRTCSessionEvent, M
* @deprecated This will be made private in a future release.
*/
public getEncryptionKeys(): IterableIterator<[string, Array<Uint8Array>]> {
// the returned array doesn't contain the timestamps
return this.getEncryptionKeysInternal();
}

private getEncryptionKeysInternal(): IterableIterator<[string, Array<Uint8Array>]> {
// the returned array doesn't contain the timestamps
return Array.from(this.encryptionKeys.entries())
.map(([participantId, keys]): [string, Uint8Array[]] => [participantId, keys.map((k) => k.key)])
Expand Down
Loading